Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setting CHPL_DEVELOPER to a falsy value be respected #26425

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Dec 17, 2024

Makes sure setting CHPL_DEVELOPER to a falsy value is respected, by using the isTrue function in our Makefiles rather than ifdef.

Testing

  • make clobber && make all frontend-shared && make check and then used file $(find build/runtime -name chpl-comm-diags.o); ls modules/TAGS; file $(find build -name ifa_vars.cpp.o); file $(find build -name codegen.cpp.o) to check if debug information was used
    • with CHPL_DEVELOPER unset
    • with CHPL_DEVELOPER=0 set
    • with CHPL_DEVELOPER=false set
    • with CHPL_DEVELOPER=1 set
    • with CHPL_DEVELOPER=true set
    • with CHPL_DEVELOPER=T set
    • with CHPL_DEVELOPER=n set
    • with CHPL_DEVELOPER=y set

Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 requested a review from arezaii January 7, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant