Fix issues with using a non-default system LLVM with CHPL_LLVM_CONFIG #26428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compiler build issues when using a system LLVM that is different than the standard LLVM. For example, an LLVM installed at
/usr/
would conflict with an LLVM installed at/home/user/llvm-install
(which was accessed byCHPL_LLVM_CONFIG=/home/user/llvm-install
)Subsumes #26212 and #26402
Previous work had tried to take advantage of various clang/gcc flags to achieve the right behavior, however this not working in all cases. This PR does following.
-I
Testing
make check
with HOST_CC=clang, LLVM=systemmake check
with HOST_CC=clang, LLVM=bundledmake check
with HOST_CC=clang, LLVM=system, LLVM_CONFIG=/some/path, with/without a normal system LLVMmake check
with HOST_CC=gnu, LLVM=systemmake check
with HOST_CC=gnu, LLVM=bundledmake check
with HOST_CC=gnu, LLVM=system, LLVM_CONFIG=/some/path, with/without a normal system LLVM[Reviewed by @mppf]