Dyno: fixes to timing script and infrastructure #26463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small fix to the timing script, and adjust
testInteractive
to allow saving timing information across generations.The fix to the timing script avoids division by zero (which happens often on my machine). I've run into the issue many times, but each time neglected to submit a simple fix.
The change to
testInteractive
adds a new--time-all-generations
switch totestInteractive
which configures it to continue gathering query timings across generations, rather than saving the latest generation's timing and discarding others. This way, it's possible to measure the impact of changes to the query system on performance.My sample script to gather performance switching back and forth between two files:
Reviewed by @benharsh -- thanks!
Running the script as
./script somefile
, you can then feedsomefile
intofrontend/util/analyze-query-trace
.