Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with 32-bit builds on allocations support #26467

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

e-kayrakli
Copy link
Contributor

@e-kayrakli e-kayrakli commented Jan 6, 2025

We observed some issues with building the runtime on 32-bit systems. This is a fallout from #26118.

This PR addresses the issue, which was about pointer sizes. While there, I also adjusted a size variable to have size_t type for better conformance to standards/conventions. The Chapel wrapper allocations still casts things to uint, so I don't expect any behavioral change for the user.

Test:

  • local library/standard/Memory/Diagnostics/allocationsIter.chpl
  • no-local library/standard/Memory/Diagnostics/allocationsIter.chpl

@e-kayrakli e-kayrakli merged commit 54cedd7 into chapel-lang:main Jan 7, 2025
8 checks passed
@e-kayrakli e-kayrakli deleted the allocations-fix-32bit branch January 7, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants