Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dyno: check return types when validating interface constraints #26471

Merged
merged 12 commits into from
Jan 17, 2025
Merged

Dyno: check return types when validating interface constraints #26471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
370457f
Split function template matching code into helpers
DanilaFe Jan 4, 2025
d2645e8
Add checks for return types to interface constraint checking
DanilaFe Jan 6, 2025
3af0cfe
Add tests for return type checking
DanilaFe Jan 6, 2025
a72d53f
Add checks for return intents
DanilaFe Jan 6, 2025
13db172
Add more tests for return intent checking
DanilaFe Jan 6, 2025
dc1f741
Test 'any return intent' pragma
DanilaFe Jan 6, 2025
14f97a3
Avoid threading through a bunch of data by using a struct.
DanilaFe Jan 7, 2025
e3a13a0
Fix substituting types in basic class types
DanilaFe Jan 7, 2025
722cebc
Fix resolving return type that depends on associated types
DanilaFe Jan 7, 2025
4bcae43
Add comment
DanilaFe Jan 7, 2025
8c41029
Remove unused variable
DanilaFe Jan 7, 2025
2550266
Fix typo
DanilaFe Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions frontend/include/chpl/types/BasicClassType.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ class BasicClassType final : public ManageableType {

const Type* substitute(Context* context,
const PlaceholderMap& subs) const override {
if (!parentType_) {
CHPL_ASSERT(name() == USTR("RootClass"));
return this;
}

return get(context, id(), name(),
Type::substitute(context, parentType_, subs),
Type::substitute(context, (const BasicClassType*) instantiatedFrom_, subs),
Expand Down
Loading
Loading