-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it compatible with AGP 8 #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciriousjoker
force-pushed
the
added_namespace
branch
from
September 16, 2023 13:12
f55e723
to
e5204d0
Compare
ciriousjoker
force-pushed
the
added_namespace
branch
from
October 19, 2023 00:38
e5204d0
to
2a20dbc
Compare
Can someone merge this please? |
cb-haripriyan
approved these changes
Dec 27, 2023
When is this going to be merged? |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@cb-haripriyan Can you merge this please, so we can finally stop using our fork? Also, here's the PR for the v1.0.0: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Android gradle plugin (AGP) in version 8 requires namespaces.
The solution was copied from the official cloud_firestore package and leads to a successful gradle sync.