-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Billing library 5 updates #169
Billing library 5 updates #169
Conversation
Major Release to support IAP
Update post release docs into master [skip ci]
Update readme [skip ci]
Restore purchases
Update post release docs into master
Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.13 to 3.9.19. - [Release notes](https://github.com/patriksimek/vm2/releases) - [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md) - [Commits](patriksimek/vm2@3.9.13...3.9.19) --- updated-dependencies: - dependency-name: vm2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…9.19 build(deps): bump vm2 from 3.9.13 to 3.9.19 [skip ci]
Update post release docs into master
Retry Validation to sync receipts to Chargebee
Update post release docs into master
Update post release docs into master
fix: fixes validate receipt method
Update post release docs into master
…encies chore: updates native dependencies
Update post release docs into master
Create SECURITY.md
chore(docs): add permission steps
Update post release docs into master
BREAKING CHANGE: Handles changes for Android Billing Library 5
|
||
|
||
### Bug Fixes | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cb-haripriyan Just curious why our change log starts with small letters. I checked a few other open-source products they seem to follow normal English
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change logs are autogenerated from the commit messages, using release-it.
We can modify the template as we need.
} | ||
|
||
fun SubscriptionOffer.toMap(product: CBProduct): WritableMap { | ||
val pricingPhase = pricingPhases.last() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cb-haripriyan Code optimized for readability with apply if it makes sense
return WritableNativeMap().apply {
putString("productId", product.productId)
putString("productTitle", product.productTitle)
putDouble("productPrice", convertPriceAmountInMicros(product.skuDetails))
putString("productCurrencyCode", product.skuDetails.priceCurrencyCode)
putString("productId", product.id)
putString("productType", product.type.value)
putString("baseProductId", basePlanId)
putString("offerToken", offerToken)
putString("offerTitle", product.title)
putDouble("offerPrice", pricingPhase.convertPriceAmountInMicros())
putString("offerCurrencyCode", pricingPhase.currencyCode)
offerId?.let { putMap("offer", offer()) }
}
No description provided.