Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billing library 5 updates #169

Merged
merged 93 commits into from
Dec 5, 2023
Merged

Billing library 5 updates #169

merged 93 commits into from
Dec 5, 2023

Conversation

cb-haripriyan
Copy link
Collaborator

No description provided.

cb-haripriyan and others added 30 commits May 2, 2023 12:53
Major Release to support IAP
Update post release docs into master [skip ci]
Update post release docs into master
Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.13 to 3.9.19.
- [Release notes](https://github.com/patriksimek/vm2/releases)
- [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md)
- [Commits](patriksimek/vm2@3.9.13...3.9.19)

---
updated-dependencies:
- dependency-name: vm2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…9.19

build(deps): bump vm2 from 3.9.13 to 3.9.19 [skip ci]
Update post release docs into master
Retry Validation to sync receipts to Chargebee
Update post release docs into master
@cb-haripriyan cb-haripriyan changed the base branch from next to master December 5, 2023 14:11
@cb-haripriyan cb-haripriyan changed the base branch from master to next December 5, 2023 14:11


### Bug Fixes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cb-haripriyan Just curious why our change log starts with small letters. I checked a few other open-source products they seem to follow normal English

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change logs are autogenerated from the commit messages, using release-it.
We can modify the template as we need.

}

fun SubscriptionOffer.toMap(product: CBProduct): WritableMap {
val pricingPhase = pricingPhases.last()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cb-haripriyan Code optimized for readability with apply if it makes sense

return WritableNativeMap().apply {
putString("productId", product.productId)
putString("productTitle", product.productTitle)
putDouble("productPrice", convertPriceAmountInMicros(product.skuDetails))
putString("productCurrencyCode", product.skuDetails.priceCurrencyCode)
putString("productId", product.id)
putString("productType", product.type.value)
putString("baseProductId", basePlanId)
putString("offerToken", offerToken)
putString("offerTitle", product.title)
putDouble("offerPrice", pricingPhase.convertPriceAmountInMicros())
putString("offerCurrencyCode", pricingPhase.currencyCode)

    offerId?.let { putMap("offer", offer()) }
}

@cb-haripriyan cb-haripriyan merged commit b94989f into chargebee:next Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants