Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes :
Modify the models (both v1 and v2) so that they can take arbitrary batch size.
Currently the batch size is fixed once you create the model, which is not practical when the number of objects varies across different frames. I modified the code so that it can infer the batch size from the tensors' shape automatically, i.e. arbitrary batch size is possible. To use this feature, simply set
batch_size=None
.Delete the duplicated
+size_residuals
at line 109 in filemodel_util.py
as suggested in Size residuals added twice when calculating corners #43. This change requires the model to be retrained..Add
object_point_cloud_xyz
andmask_xyz_mean
toend_points
in both v1 and v2, to allow 3d box regression directly from extracted points. That is, suppose we already know that some points belong to an object (for example a car), we can directly regress a 3d box from these points, without passing by the segmentation part.Example usage (similar as in
test.py
):