-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(v2) feat: query background color by default #1195
base: v2-exp
Are you sure you want to change the base?
Conversation
This commit makes the program query the terminal for its background color by default. This is useful if you want to enable automatic background color detection for your program. It also adds a new option `WithoutBackgroundColor` to disable this behavior.
For the alpha, why don't we keep it opt in? If we find the friction is too high we can merge this. To your point, it would be good to avoid the heavy query when we can. |
Aren't users used to this behaviour by default though? I do agree that less is more overall though. Just might feel weird at first if they're used to a certain behaviour |
f855f13
to
7cb35d7
Compare
I agree with @bashbunni tbh. Since we're moving to pure lipgloss and removing the lipgloss "hack" in bubbletea@v2 that queries the terminal on start, we need to send the terminal bg color on start similar to |
Because checking for the background color is so much more involved now (you need to listen for |
What's the benefit of having the user fire off that request? Aren't they querying the terminal for its environment info for the WindowSizeMsg anyway? |
This commit makes the program query the terminal for its background color by default. This is useful if you want to enable automatic background color detection for your program.
It also adds a new option
WithoutBackgroundColor
to disable this behavior.