fix(slurmctld,slurmd): clean up TODO comments

Changes: * slurmctld: create gh issue for enabling Juju Secrets. * slurmd: remove stale TODO comment from development work. Signed-off-by: Jason C. Nucciarone <[email protected]>
charmed-hpc · Nov 18, 2024 · 2ba972f · 2ba972f
1 parent f0cadeb
commit 2ba972f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/charms/slurmctld/src/charm.py b/charms/slurmctld/src/charm.py
@@ -89,8 +89,8 @@ def _on_install(self, event: InstallEvent) -> None:
             if self.unit.is_leader():
                 self._slurmctld.install()
 
-                # TODO: <make github issue> -
-                #  Use Juju secrets instead of StoredState for exchanging keys between units.
+                # TODO: https://github.com/charmed-hpc/slurm-charms/issues/38 -
+                #  Use Juju Secrets instead of StoredState for exchanging keys between units.
                 self._slurmctld.jwt.generate()
                 self._stored.jwt_rsa = self._slurmctld.jwt.get()
                 self._slurmctld.munge.key.generate()

diff --git a/charms/slurmd/src/charm.py b/charms/slurmd/src/charm.py
@@ -213,7 +213,6 @@ def _on_show_nhc_config(self, event: ActionEvent) -> None:
         except FileNotFoundError:
             event.set_results({"nhc.conf": "/etc/nhc/nhc.conf not found."})
 
-    # TODO: Just use the slurmutils models here.
     def _on_node_config_action_event(self, event: ActionEvent) -> None:
         """Get or set the user_supplied_node_conifg.