fix parsing of nested k=v config values #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes fix the parser so that it correctly parses user defined input where the values contain nested k=v. Adds a peer relation to get the slurmctld ingress_address from.
NucciTheBoss
requested changes
Aug 20, 2024
There was a problem hiding this comment.
I see that two changes are added in e48cdf8:
- Fix the configuration parser
- Add back the slurmctld-peer integration
Can we rebase this commit into two commits? One commit for fixing the configuration parser and the other that adds back the slurmctld-peer integration? That way when going through the commit history, we have better insight for when things were added. Also, could you quickly update the commit messages to follow the conventional commits format? Makes parsing commits easier 😃
Once the commits are rebased, I'm good to merge this PR! Thanks @jamesbeedy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the parser so that it correctly parses user defined input where the values contain nested k=v.
Adds a peer relation to get the slurmctld ingress_address from.
Fixes #14