fix(ci): do not use destructive packing when building charms for release #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the `destructive-mode` option for the `upload-charm` action to false. Pulling the down the base LXD instance will add some extra time onto the workflow run, but it make us not be dependent on the base OS of the GitHub runner VM. Eventually we'll either want to replace the `cryptography` dependency that takes so long to build, or use the `ccc` tool to cache the Slurm charms dependencies so that the build for them is quicker. Signed-off-by: Jason C. Nucciarone <[email protected]>
|
This PR needs to be landed to unblock charmed-hpc/charmed-hpc-terraform#9 |
wolsen
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the
destructive-modeoption for theupload-charmaction to false. Pulling the down the base LXD instance will add some extra time onto the workflow run, but it make us not be dependent on the base OS of the GitHub runner VM to release the Slurm charms. This is especially helpful for it we need to release multiple the Slurm charms with support for multiple bases. Eventually we'll either want to replace thecryptographydependency that takes so long to build, or use theccctool to cache the Slurm charms dependencies so that the build for them is quicker.Just for added insurance, I also updated the
CHARMCRAFT_AUTHsecret.Related issues