Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/forground notification callback #406

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mohit5189
Copy link

SDK was not sending any push event to app in case if app was in Foreground. I added change which will make sure that:

  • If local notification is enabled then will show local notification
  • If local notification is not enabled, then will call appDidReceiveRemoteNotification so that App can take required actions.

@mohit5189
Copy link
Author

Hi team

Can we merge this please.

@mohit5189
Copy link
Author

Hi Team

Can you please help for this?

@mohit5189
Copy link
Author

Hi Team

Can you please help to fix this issue... Our app foreground push handling is blocked because of this and should be issue in another apps too which have chat as submodule only.

@mohit5189
Copy link
Author

Hi Team

any help here... If we adding SDK in existing app that use forground push, This code stop push sending in our app. ChatPushHandler won't get any push in this case and our app functionality is blocked.

It should be case for many users who are not having chat only as feature,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant