Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up tower.js, Home page form fix; #34

Merged
merged 5 commits into from
Jan 21, 2024
Merged

Tidy up tower.js, Home page form fix; #34

merged 5 commits into from
Jan 21, 2024

Conversation

cyanedel
Copy link
Contributor

Home page form fix.

  • I noticed that the home page form (login/register) got cut off after I changed it last time. This is the fix for it. Now the form should hover at the middle of your window.
  • Also adjusted spacing between the form inputs. should look nicer now.

Tidy up tower.js

  • Moved all variables declaration to top, followed by events and functions.
  • Grouped all related variables (gameConf, gameState, etc).

@cyanedel
Tidy up tower.js
9002346 
Tidying up `tower.js` to make it more readable;
@cyanedel
Home page form fix
0c16325 
Fixes home page form position, reduce spacing between form inputs;
@cyanedel
Tidy up tower.js
244de05 
Grouping variables into JSON object;
@cyanedel
Remove unused function;
d954bff
chavi362
chavi362 requested changes Jan 20, 2024
View reviewed changes
Copy link
Owner

@chavi362 chavi362 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
First of all, thank you so much for your help!
I appreciate it so much!
Note that in small-medium screens, the form of sign in note seen until its end, so it impossible to register.
Can you please fix this?
Thank you so much!
Chavi

@cyanedel
Form modal placement fixes;
a8ea77a 
- Consolidated all modal controllers to the `Modal` class;
- Added overlay layer that prevents the user from interacting with other page elements when the modal is open;
- Fixed some typos;
@cyanedel
Copy link
Contributor Author

cyanedel commented Jan 21, 2024 •
edited
Loading

@chavi362 The latest changes should fix this issue. If the modal is too long, the user should be able to scroll to see the rest of the content but to achieve this, I have to move the modal to the top with some hard-coded margin. Which potentially could fix issue #26.

I have also added an overlay layer behind the modal to prevent users from interacting with page elements when the modal is shown.

@cyanedel cyanedel requested a review from chavi362 January 21, 2024 06:07
chavi362
chavi362 approved these changes Jan 21, 2024
View reviewed changes
Copy link
Owner

@chavi362 chavi362 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's 👌!
Thanks!

@chavi362 chavi362 merged commit f1ef0ae into chavi362:main Jan 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chavi362 chavi362 chavi362 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyanedel @chavi362