Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Virtual Keyboard with Emoji Support and Search Functionality #103

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

TumiMoshou
Copy link

This pull request introduces some changes to the virtual keyboard feature, including emoji support and search functionality.

The following changes have been made:

  • Added import statement for useState hook in EmojiKeyBoard.jsx.
  • Implemented search functionality in the EmojiKeyBoard component, allowing users to filter emojis based on search terms.
  • Added emoji descriptions for various categories, including smileys, animals, food, drinks, activities, travel, objects, hearts, symbols, and flags.

These changes improve the user experience by providing convenient access to a wide range of emojis and making it easier for users to find and select emojis using the search feature.

Please review the changes and provide any feedback or suggestions for improvement. Thank you!

Copy link
Owner

@chavi362 chavi362 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributing!
Note that there is a bug in your PR.
look what happens when clicking on the emoji button:
image

@chavi362
Copy link
Owner

@TumiMoshou can you please repair the bug? Thanks you so much!

@TumiMoshou
Copy link
Author

@chavi362 Hello, can you please let me know if you can see the changes. I made them but I am not sure if my pull request was successful, it seems to have worked on my side.

Screenshot 2024-03-13 at 06 37 48 Screenshot 2024-03-13 at 06 37 56

@chavi362
Copy link
Owner

Oh, I don't see your changes...
This is what I see
image
Please try to search about updating PR.
If you don't succeed, you can simplicity open a new PR with the bug fixing,
Good Luck!

@TumiMoshou
Copy link
Author

@chavi362 Hello, I know what I am about to ask is a bit unorthodox but I don't know what else to do because nothing seems to work. I tried to push the changes but unfortunately I get an error stating that the working tree is clean (here is a copy from my terminal: Tumis-Air:components reitumetsemoshou$ git status
On branch feature/EmojiFeature
nothing to commit, working tree clean). I even tried making a new branch just for the bug fix but I get a similar message. I tried creating a new pull request like you suggested but it would not allow me. I have even tried searching online and even got some help but nothing seems to work. The most I can do is send screenshot of the updated code as I do not know what more to do:

Screenshot 2024-03-22 at 10 44 15

Here is the screenshot that shows I made the changes last week along with the commit number if maybe that could help you in any way:

Screenshot 2024-03-22 at 10 45 25 Screenshot 2024-03-22 at 10 46 17

Apologies for the inconvenience caused. You can delete my branch altogether and disregard my merge request so that it does not affect your project, I really don't mind because I do not know what more to do.

@TumiMoshou
Copy link
Author

@chavi362 when I check, it states that I have 16 commits and when I count the commits (which includes the bug fix) it adds up to 16. When I check the screenshot of what you showed me, I see your screenshot also shows 16 commits so I don't know what more to do if we have the same number of commit yet the changes are not showing. So I think it is better if you disregard my merge request

Copy link
Owner

@chavi362 chavi362 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, now I see your changes.
The bug is repaired!
But, I still don't see the emojis.
image
Can You please repair this?

@TumiMoshou
Copy link
Author

Hello, sorry for the late response. I have been a bit busy. I tried to fix the fact that the emojis do not show but it just creates more and more different problems regardless of how much I try. I am struggling with it and do not want to waste more of your time trying to work on this so you can just disregard any changes I have made and ignore the pull request. Apologies for the inconvenience and delay caused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants