Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished adding feature for returning npm link from package.json #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Manpreet-Bhatti
Copy link
Contributor

No description provided.

Copy link
Member

@ralph-dev ralph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahandfarahani Will this work to generate an NPM Badge on your README? it should but I don't think the UI was set up here?

@sahandfarahani
Copy link
Contributor

@sahandfarahani Will this work to generate an NPM Badge on your README? it should but I don't think the UI was set up here?

@ralph-dev there is a section for Badge and when I do copy it to clipboard I get "npm version"
But I don't understand this code... doesn't it have to do something with readmeCongif?
Cause it has only put "npmPackageUrl": "" inside package.json and returns the value at createNpmFormatting.ts

@ralph-dev
Copy link
Member

@sahandfarahani Will this work to generate an NPM Badge on your README? it should but I don't think the UI was set up here?

@ralph-dev there is a section for Badge and when I do copy it to clipboard I get "npm version"

But I don't understand this code... doesn't it have to do something with readmeCongif?

Cause it has only put "npmPackageUrl": "" inside package.json and returns the value at createNpmFormatting.ts

It's just supposed to show a badge on the readme from the readme config settings. Not sure what's happening here though

@Manpreet-Bhatti
Copy link
Contributor Author

@sahandfarahani Will this work to generate an NPM Badge on your README? it should but I don't think the UI was set up here?

@ralph-dev there is a section for Badge and when I do copy it to clipboard I get "npm version"
But I don't understand this code... doesn't it have to do something with readmeCongif?
Cause it has only put "npmPackageUrl": "" inside package.json and returns the value at createNpmFormatting.ts

It's just supposed to show a badge on the readme from the readme config settings. Not sure what's happening here though

Ok so from the looks of this I'm assuming the npmPackageUrl key should be put into the readme config file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants