apply new rules #177
Merged
apply new rules #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlansley
requested changes
Oct 30, 2024
package.json
Outdated
| @@ -43,7 +43,7 @@ | |||
| "jest": "^29.7.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "@checkdigit/eslint-plugin": "7.0.0", | |||
| "@checkdigit/eslint-plugin": "7.3.0-PR.75-4246", | |||
|
Beta Published - Install Command: |
carlansley
requested changes
Oct 30, 2024
| @@ -43,7 +43,7 @@ | |||
| "jest": "^29.7.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "@checkdigit/eslint-plugin": "7.0.0", | |||
| "@checkdigit/eslint-plugin": "7.2.0", | |||
There was a problem hiding this comment.
there are updates to other plugins, should we update those deps also?
There was a problem hiding this comment.
on second thoughts, if you've already tested this beta with repos, probably best to go out as-is. lmk
There was a problem hiding this comment.
maybe we push this out first, because the other plugin deps need time to test, e.g.:
@typescript-eslint/*: 8.11.0 introduced some issue which crash rule testers, it's unclear if 8:12.0 actually fixes it or not- sonarjs can be a big change, and not sure if we want those new rules or not (e.g. require each file to have a test file with it, etc.)
carlansley
approved these changes
Oct 30, 2024
|
✅ PR review status - All reviews completed and approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
Fixes #176