Skip to content

Commit

Permalink
Allow esm only package import (#71)
Browse files Browse the repository at this point in the history
  • Loading branch information
le-cong authored Jan 26, 2024
1 parent 58fd589 commit 766205b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@checkdigit/github-actions",
"version": "1.0.1",
"version": "1.0.2",
"description": " Provides supporting operations for github action builds.",
"typings": "./dist/index.d.ts",
"main": "./dist/index.js",
Expand Down
7 changes: 0 additions & 7 deletions src/check-imports/packages-not-allowed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,12 @@ export type NotAllowed = [Name, Range, Reason];

// const UNSTABLE =
// 'Higher versions are unstable and break tests in Check Digit services. This can be removed from the Not Allowed list when stability improves.';
const ESM_UNSUPPORTED =
'This version and higher use ESM which Check Digit does not support. This can be removed when Check Digit supports ESM.';
const ESM_UNSUPPORTED_HIGHER =
'Higher versions use ESM which Check Digit does not support. This can be removed when Check Digit supports ESM.';

/*
This is the list of packages that are not allowed to be imported.
*/
const notAllowed: NotAllowed[] = [
// ['@aws-sdk/client-*', '>3.387.0', UNSTABLE], // example of an unstable package
['got', '>=12.0.0', ESM_UNSUPPORTED],
['get-port', '>=6.0.0', ESM_UNSUPPORTED],
['antlr4', '>4.9.3', ESM_UNSUPPORTED_HIGHER],
];

export default notAllowed;

0 comments on commit 766205b

Please sign in to comment.