Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing json5 #930

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix: add missing json5 #930

merged 1 commit into from
Jan 26, 2024

Conversation

ferrandiaz
Copy link
Contributor

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

add missing json5 dependency

@ferrandiaz ferrandiaz requested a review from clample January 26, 2024 09:09
@ferrandiaz ferrandiaz merged commit df98fb6 into main Jan 26, 2024
3 checks passed
@ferrandiaz ferrandiaz deleted the ferran/add-missing-json5 branch January 26, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clample clample clample approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferrandiaz @clample