Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multistep glob pattern [sc-18837] #940

Merged

Conversation

maxigimenez
Copy link
Member

@maxigimenez maxigimenez commented Mar 6, 2024

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Add support for multistep glob patterns to load checks

Copy link

This pull request has been linked to Shortcut Story #18837: Add multistep support to glob pattern in the CLI.

@maxigimenez maxigimenez marked this pull request as ready for review March 7, 2024 11:15
@maxigimenez maxigimenez requested a review from clample March 7, 2024 12:00
Copy link
Collaborator

@clample clample left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@maxigimenez maxigimenez merged commit c6e8165 into main Mar 12, 2024
3 checks passed
@maxigimenez maxigimenez deleted the maxigimenez/sc-18837/add-multistep-support-to-glob-pattern-in branch March 12, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants