add GetStaticIPs function and test case #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benben
requested review from
maxigimenez,
pilimartinez,
Antoine-C and
shiini2
as code owners
benben
force-pushed
the
ben/add-static-ips
branch
from
e40ac8b to
b145cd9
Compare
danielpaulus
approved these changes
Jul 1, 2024
maxigimenez
approved these changes
Jul 1, 2024
benben
force-pushed
the
ben/add-static-ips
branch
from
b41e738 to
699e5c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Components
Style
go fmtThis adds a new function
GetStaticIPsto expose our current static IP ranges in the SDK. Will later need this for the terraform provider.