-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pascal/signed url continued #412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c176ff
to
9a5cadf
Compare
Pascal-Delange
commented
Dec 19, 2023
@@ -168,3 +172,17 @@ func (repository *GcsRepositoryImpl) DeleteFile(ctx context.Context, bucketName, | |||
|
|||
return nil | |||
} | |||
|
|||
func (repo *GcsRepositoryImpl) GenerateSignedUrl(ctx context.Context, bucketName, fileName string) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this alternative which seemed to work better when running locally :
func (repo *GcsRepositoryImpl) GenerateSignedUrl(ctx context.Context, bucketName, fileName string) (string, error) {
serviceAccount := "[email protected]"
c, err := credentials.NewIamCredentialsClient(ctx)
if err != nil {
panic(err)
}
// This code will typically not run locally if if you target the real GCS repository, because SignedURL only works with service account credentials (not end user credentials)
// Hence, run the code locally with the fake GCS repository always
bucket := repo.getGCSClient(ctx).Bucket(bucketName)
return bucket.
SignedURL(
fileName,
&storage.SignedURLOptions{
Method: http.MethodGet,
GoogleAccessID: serviceAccount,
SignBytes: func(b []byte) ([]byte, error) {
req := &credentialspb.SignBlobRequest{
Payload: b,
Name: serviceAccount,
}
resp, err := c.SignBlob(ctx, req)
if err != nil {
panic(err)
}
return resp.SignedBlob, err
},
Expires: time.Now().Add(signedUrlExpiryHours * time.Hour),
},
)
}
But only when using application-default credentials that impersonate a service account - so not practical
use stats 302 not 301
af56132
to
94f2932
Compare
balzdur
approved these changes
Dec 19, 2023
Co-authored-by: Thomas Lathuiliere <[email protected]>
github-zoe-cade
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service account permissions to be checked and adjusted manually and terraformed in another PR
Prereq for checkmarble/marble-frontend#319