Thomas/check email verification #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balzdur
commented
Jan 16, 2024
Comment on lines
+9
to
+10
| type FireBaseTokenRepository interface { | ||
| VerifyFirebaseToken(ctx context.Context, firebaseToken string) (models.FirebaseIdentity, error) |
There was a problem hiding this comment.
Only declare the interface of what is expected to be injected here
There was a problem hiding this comment.
let's have a look at this one tomorrow if you want : it's probably not the right place to put this
| FirebaseTokenRepository: FireBaseTokenRepository{ | ||
| firebaseClient: firebaseClient, | ||
| }, | ||
| FirebaseTokenRepository: firebase.New(firebaseClient), |
There was a problem hiding this comment.
Inject an instance of the already factorised firebase repository
Comment on lines
+9
to
+10
| type FireBaseTokenRepository interface { | ||
| VerifyFirebaseToken(ctx context.Context, firebaseToken string) (models.FirebaseIdentity, error) |
There was a problem hiding this comment.
let's have a look at this one tomorrow if you want : it's probably not the right place to put this
| } | ||
| return c.verifier.VerifySessionCookie(ctx, firebaseToken) | ||
| if token.Firebase.SignInProvider == "password" && token.Claims["email_verified"] == false { |
Pascal-Delange
approved these changes
Jan 19, 2024
balzdur
added a commit
that referenced
this pull request
Jan 19, 2024
balzdur
added a commit
that referenced
this pull request
Jan 19, 2024
* feat(auth): return error message when user is unknown * feat(auth): add email verification check (#441)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR :
Linear Issue