fix: span was leaking, leading to long traces #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pascal-Delange
force-pushed
the
pascal/improve-batch-scenario-traces
branch
from
9be0ed2 to
144bcf3
Compare
balzdur
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was happening is that in some cases (trigger mismatch, specifically) we never called span.End() (or at least we did so very late, because the deferred call was happening at the end of the batch execution). So we are seing some long spans towards the end of the batch execution (see screenshot).
TBH I still don't understand why they are not even longer - though probably the explanation is that there are many such long spans, all with deferred .End() queued, and the most recent ones are simply ended first when the function ends, and after a certain number the trace collection rate limiting kicks in (otherwise we'd see spans minutes old)
Anyway, I fix this by doing the span generation and scenario execution in a closure so that the deferred End does not wait forever.