Adding IP_TTL socket option while restoring #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rahulk789 <[email protected]>
rst0git
reviewed
Nov 26, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## criu-dev #2300 +/- ##
============================================
- Coverage 70.55% 70.30% -0.25%
============================================
Files 132 134 +2
Lines 33508 34044 +536
============================================
+ Hits 23642 23936 +294
- Misses 9866 10108 +242 ☔ View full report in Codecov by Sentry. |
rst0git
reviewed
Nov 29, 2023
Signed-off-by: rahulk789 <[email protected]>
|
Any updates on this? |
|
A friendly reminder that this PR had no activity for 30 days. |
Snorch
reviewed
Feb 6, 2024
| if (ioe->has_ttl) | ||
| ret |= restore_opt(sk, SOL_IP, IP_TTL, &ioe->ttl); | ||
|
|
||
| } |
There was a problem hiding this comment.
Excess newline and bad alignment.
upd: #2344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #2007