Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: fix compilation on alpine #2319

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

avagin
Copy link
Member

@avagin avagin commented Dec 28, 2023

Starting with the musl v1.2.4~69, _GNU_SOURCE doesn't set _LARGEFILE64_SOURCE.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61224f2) 70.51% compared to head (3848264) 70.51%.

❗ Current head 3848264 differs from pull request most recent head 40efff3. Consider uploading reports for the commit 40efff3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           criu-dev    #2319   +/-   ##
=========================================
  Coverage     70.51%   70.51%           
=========================================
  Files           133      133           
  Lines         33534    33534           
=========================================
  Hits          23646    23646           
  Misses         9888     9888           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avagin avagin force-pushed the criu-musl-largefile branch from 595c786 to 779cd75 Compare December 28, 2023 06:04
Starting with the musl v1.2.4~69, _GNU_SOURCE doesn't set _LARGEFILE64_SOURCE.

Fixes checkpoint-restore#2313
Signed-off-by: Andrei Vagin <[email protected]>
@avagin avagin force-pushed the criu-musl-largefile branch from 779cd75 to 40efff3 Compare December 28, 2023 07:05
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avagin avagin merged commit 50aa6da into checkpoint-restore:criu-dev Dec 30, 2023
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants