Restore a thread to a correct v1 cgroup #2347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StepanPieshkin
force-pushed
the
cgroups_v1
branch
from
4b996f1 to
453f0a9
Compare
minhbq-99
reviewed
Feb 12, 2024
StepanPieshkin
force-pushed
the
cgroups_v1
branch
from
453f0a9 to
7f221a9
Compare
osctobe
approved these changes
Feb 13, 2024
StepanPieshkin
force-pushed
the
cgroups_v1
branch
from
7f221a9 to
32b2cae
Compare
rst0git
reviewed
Feb 14, 2024
Currently we have checkpoint/restore support only of cgroup v2 threaded controllers. Threads originating in cgroup v1 environments will be restored to the main thread's cgroup. This change extends the support for a cgroups v1. Signed-off-by: Stepan Pieshkin <[email protected]>
Co-developed-by: Stepan Pieshkin <[email protected]> Signed-off-by: Stepan Pieshkin <[email protected]> Signed-off-by: Michal Clapinski <[email protected]>
StepanPieshkin
force-pushed
the
cgroups_v1
branch
from
32b2cae to
48c95f6
Compare
Snorch
reviewed
Feb 16, 2024
| #include <pthread.h> | ||
| #include "zdtmtst.h" | ||
|
|
||
| const char *test_doc = "Check that cgroup layout of threads is preserved"; |
There was a problem hiding this comment.
Note: clang-format is complaining about alignment here. s/\t/ / here and below.
Snorch
reviewed
Feb 16, 2024
|
|
||
| int p1[2], pr[2]; | ||
|
|
||
| void *child(void *args) |
There was a problem hiding this comment.
Misleading name for a thread, don't you think?
avagin
reviewed
Feb 17, 2024
| * then it reports the restore status (int). | ||
| */ | ||
|
|
||
| pipe(p1); |
There was a problem hiding this comment.
pls handler errors here and in other places.
avagin
reviewed
Feb 17, 2024
|
|
||
| if (mkdir(dirname, 0700) < 0) { | ||
| pr_perror("Can't make dir"); | ||
| goto out; |
There was a problem hiding this comment.
it has to exit with a non-zero code in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have checkpoint/restore support only of cgroup v2 threaded controllers. Threads originating in cgroup v1 environments will be restored to the main thread's cgroup. This change extends the support for a cgroups v1.