Add support for reset-on-fork scheduling flag #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rst0git
force-pushed
the
sched-reset-on-fork
branch
from
fed04e0 to
f5ed2ac
Compare
avagin
reviewed
Mar 5, 2024
avagin
reviewed
Mar 5, 2024
avagin
reviewed
Mar 5, 2024
rst0git
force-pushed
the
sched-reset-on-fork
branch
from
f5ed2ac to
c02410b
Compare
This patch extends CRIU with support for SCHED_RESET_ON_FORK. When the SCHED_RESET_ON_FORK flag is set, the following rules apply for subsequently created children: - If the calling thread has a scheduling policy of SCHED_FIFO or SCHED_RR, the policy is reset to SCHED_OTHER in child processes. - If the calling process has a negative nice value, the nice value is reset to zero in child processes. (See 'man 7 sched') Fixes: checkpoint-restore#2359 Signed-off-by: Radostin Stoyanov <[email protected]>
This patch extends the sched_policy00 test case to verify that the SCHED_RESET_ON_FORK flag is restored correctly. Signed-off-by: Radostin Stoyanov <[email protected]>
rst0git
force-pushed
the
sched-reset-on-fork
branch
from
c02410b to
6673a3b
Compare
|
I built this PR and can confirm the error I was getting is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends CRIU with checkpoint/restore support for the reset-on-fork scheduling flag (
SCHED_RESET_ON_FORK). When this flag is set, the following rules apply for subsequently created children:If the calling thread has a scheduling policy of
SCHED_FIFOorSCHED_RR, the policy is reset toSCHED_OTHERin child processes.If the calling process has a negative nice value, the nice value is reset to zero in child processes.
(See
man 7 sched)Fixes: #2359