Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.config: fix/improve feature warnings. #2382

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Apr 5, 2024

  1. Tell which RPMs or DEBs are required in all cases.

  2. Use $(info ...) everywhere.

  3. Drop extra nested $(info), instead use (a document) a simpler kludge.

  4. Simplify and unify the language, add missing periods.

Before:

Note: Building without setproctitle() and strlcpy() support.
      To enable these features, please install libbsd-devel (RPM) / libbsd-dev (DEB).
Note: Building criu without amdgpu_plugin.
Note: libdrm and libdrm_amdgpu are required to build amdgpu_plugin.
Makefile.config:53: Warn: you have no libnftables installed
Makefile.config:54: Warn: Building without nftables support

After:

Note: Building without setproctitle() and strlcpy() support.
      Install libbsd-devel (RPM) / libbsd-dev (DEB) to fix.
Note: Building without amdgpu_plugin.
      Install libdrm-devel (RPM) or libdrm-dev (DEB) to fix.
Warn: Building without nftables support.
      Install nftables-devel (RPM) or libnftables-dev (DEB) to fix.

1. Tell which RPMs or DEBs are required in all cases.

2. Use $(info ...) everywhere.

3. Drop extra nested $(info), instead use (a document) a simpler kludge.

4. Simplify and unify the language, add missing periods.

Signed-off-by: Kir Kolyshkin <[email protected]>
@avagin avagin merged commit 9a282a5 into checkpoint-restore:criu-dev Apr 9, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants