zdtm: verify that criu repo file system allows resolving device files #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We put several device files into zdtm container through its root file system which is the same file system criu git resides in. We do it like this to overcome inability to create character and block device files in user namespaces. So even if we put those device files into zdtm container in any other way, in 'uns' flavor CRIU would not be able to restore those device files. Other option can be - creating auxiliary tmpfs mount and add it into zdtm container as external mount, but that looks like an overkill for this problem. Let's print a clear error so that user can either mount current file system without 'nodev" or put criu somewhere else. Fixes: checkpoint-restore#2441 Signed-off-by: Pavel Tikhomirov <[email protected]>
Snorch
force-pushed
the
zdtm-verify-device-file-resolving
branch
from
acf8286 to
bbaaaa7
Compare
rst0git
reviewed
Jul 15, 2024
| except IOError as e: | ||
| if e.errno != errno.EACCES: | ||
| raise e | ||
| raise test_fail_exc("The filesystem of CRIU repo should not have 'nodev' flag. Consider putting CRIU on appropriate file system to run ZDTM.") |
There was a problem hiding this comment.
It might be good to add \n:
Suggested change
| raise test_fail_exc("The filesystem of CRIU repo should not have 'nodev' flag. Consider putting CRIU on appropriate file system to run ZDTM.") | |
| raise test_fail_exc("\nThe filesystem of CRIU repo should not have 'nodev' flag. Consider putting CRIU on appropriate file system to run ZDTM.") |
[root@thinkpad:/tmp/criu/test] <base> 1 # python3 ./zdtm.py run -t zdtm/static/busyloop00 -f ns
userns is supported
=== Run 1/1 ================ zdtm/static/busyloop00
======================= Run zdtm/static/busyloop00 in ns =======================
Test zdtm/static/busyloop00 FAIL at
The filesystem of CRIU repo should not have 'nodev' flag. Consider putting CRIU on appropriate file system to run ZDTM.
##################################### FAIL #####################################
|
"External mount" approach is more robust, so closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We put several device files into zdtm container through its root file system which is the same file system criu git resides in.
We do it like this to overcome inability to create character and block device files in user namespaces. So even if we put those device files into zdtm container in any other way, in 'uns' flavor CRIU would not be able to restore those device files.
Other option can be - creating auxiliary tmpfs mount and add it into zdtm container as external mount, but that looks like an overkill for this problem. Let's print a clear error so that user can either mount current file system without 'nodev" or put criu somewhere else.
Fixes: #2441