Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/zdtm: mount a new tmpfs into the zdtm /dev #2445

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

avagin
Copy link
Member

@avagin avagin commented Jul 16, 2024

The current file system can be mounted with nodev.

Fixes #2441

@avagin avagin requested a review from Snorch July 16, 2024 07:07
@avagin avagin changed the title Zdtm dev test/zdtm: mount a new tmpfs into the zdtm /dev Jul 16, 2024
test/zdtm.py Dismissed Show dismissed Hide dismissed
test/zdtm.py Outdated
def __construct_dev(self):
for dir in self.__dev_dirs:
os.mkdir(os.path.join(self.devpath, dir))
os.chmod(os.path.join(self.devpath, dir), 0o777)

Check failure

Code scanning / CodeQL

Overly permissive file permissions High test

Overly permissive mask in chmod sets file to world writable.
test/zdtm.py Outdated Show resolved Hide resolved
test/zdtm.py Outdated Show resolved Hide resolved
test/zdtm.py Outdated Show resolved Hide resolved
test/others/mnt-ext-dev/run.sh Show resolved Hide resolved
test/zdtm.py Outdated Show resolved Hide resolved
test/zdtm/lib/ns.c Outdated Show resolved Hide resolved
test/zdtm/lib/ns.c Show resolved Hide resolved
test/zdtm.py Outdated
devpath = os.path.join(tests_root[1], "dev")
os.mkdir(devpath)
subprocess.check_call(["mount", "-t", "tmpfs", "criu-test-dev", devpath])
os.chmod(devpath, 0o755)

Check failure

Code scanning / CodeQL

Overly permissive file permissions High test

Overly permissive mask in chmod sets file to world readable.
test/zdtm.py Dismissed Show dismissed Hide dismissed
test/zdtm.py Outdated
os.mkdir(devpath)
# zdtm wants to create files on this mount. User namespace tests are
# running with custom user and group mappings.
os.chmod(devpath, 0o777)

Check failure

Code scanning / CodeQL

Overly permissive file permissions High test

Overly permissive mask in chmod sets file to world writable.
# running with custom user and group mappings.
os.chmod(devpath, 0o777)
subprocess.check_call(["mount", "-t", "tmpfs", "criu-test-dev", devpath])
os.chmod(tests_root[1], 0o755)

Check failure

Code scanning / CodeQL

Overly permissive file permissions High test

Overly permissive mask in chmod sets file to world readable.
test/zdtm.py Dismissed Show dismissed Hide dismissed
test/zdtm.py Dismissed Show dismissed Hide dismissed
test/zdtm.py Dismissed Show dismissed Hide dismissed
The current file system can be mounted with nodev.

Fixes checkpoint-restore#2441

Signed-off-by: Andrei Vagin <[email protected]>
@avagin avagin merged commit 93746eb into checkpoint-restore:criu-dev Jul 22, 2024
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants