Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #2120 #2473

Conversation

rohitsinghnaruka
Copy link

@rohitsinghnaruka rohitsinghnaruka commented Aug 29, 2024

fix : #2120

  • consider-using-enumerate (C0200)
  • updated the code by Replacing range() by Enumerate in for loop
  • updations at line 561 in criu/coredump/criu_coredump/coredump.py

@rohitsinghnaruka
Copy link
Author

@Snorch & @mihalicyn
can u review my PR ?

Copy link
Member

@Snorch Snorch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider:

  • adding coredump: prefix to your commit message
  • describing your changes in imperative mood
  • not adding filename and line to commit message, git commit already contains this information
  • adding information from PR description into commit message

note: commit message should contain:

  • why it is needed (python code style problem detected by codacy)
  • how it is done (replacing ...)

for i in range(len(infos)):
fields.append(
("name" + str(i), ctypes.c_char * (len(infos[i].name) + 1)))
for i,info in enumerate(infos):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for i,info in enumerate(infos):
for i, info in enumerate(infos):

please add a space after comma

@avagin avagin closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codacy: condition is always true/false
3 participants