Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdso: handle vvar_vclock vma-s #2539

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

avagin
Copy link
Member

@avagin avagin commented Dec 6, 2024

The vvar_vclock was introduced by [1]. Basically, the old vvar vma has been splited on two parts. In term of C/R, these two vma-s can be still treated as one.

[1] e93d2521b27f ("x86/vdso: Split virtual clock pages into dedicated mapping")

Fixes #2532

@avagin avagin force-pushed the vvar_vclock branch 2 times, most recently from 92da9b2 to 8b8893e Compare December 6, 2024 23:50
@rst0git
Copy link
Member

rst0git commented Dec 7, 2024

LGTM. I tested this patch with 6.13.0-0.rc1.20241204gitfeffde684ac2.17.fc42.x86_64 and confirmed that it fixes the error.

The vvar_vclock was introduced by [1]. Basically, the old vvar vma has
been splited on two parts. In term of C/R, these two vma-s can be still
treated as one.

[1] e93d2521b27f ("x86/vdso: Split virtual clock pages into dedicated mapping")

Signed-off-by: Andrei Vagin <[email protected]>
@rst0git rst0git merged commit 058572e into checkpoint-restore:criu-dev Dec 8, 2024
35 of 41 checks passed
@t-8ch
Copy link

t-8ch commented Dec 10, 2024

FYI soon something similar will happen on MIPS with a new [gic] mapping.

More information here:
https://lists.openvz.org/pipermail/criu/2024-November/045524.html

Looking at the archives now, is the mailing list not used anymore?
It's still linked from the website.

@avagin
Copy link
Member Author

avagin commented Dec 10, 2024

@t-8ch thank you for the head-up. The mailing list isn't used often these days and we didn't notice when it stopped working. We will fix it. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vdso: Unexpected rt vDSO area bounds
4 participants