cuda: Fix return value from CHECKPOINT_DEVICES #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. You need to add sob in the commit message: https://github.com/checkpoint-restore/criu/pull/2540/checks?check_run_id=34217028525 |
…il properly cuda-checkpoint returns the positive CUDA error code when it runs into an issue and passing that along as the return value would cause errors to get ignored Signed-off-by: Jesus Ramos <[email protected]>
jesus-ramos
force-pushed
the
fix_checkpoint_ret
branch
from
802b723 to
c3ffe66
Compare
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cuda-checkpoint fails an operation it always returns the positive CUDA error code. In CHECKPOINT_DEVICES that was getting passed up as the failure code from one of the calls so if the operation failed we would write the failure to the log but not stop the dump since that checked for error values less than 0.