Metadata Integration

[gaurabdg]

Draft PR to track progress

PoC

As you can see module description, tokens/enum values are all working perfectly after making the commit changes.

Before:

After:

Overall working of the plugin

Before:

After:

Working of createMeta() - Modules which are not present in the eclipse-cs metafiles, are directly fetched from checkstyle, hence proving that we dont need to update the files manually(as has been done in #245).

Here, the eclipse-cs meta files are the master ones, but the checkstyle JAR versionin this PR is 8.35, where a new check PatternVariableName was introduced. You can see that it is reflecting properly.

SevNTU is working as before, not being affected by these changes

Updated metadata is also showing up for those checks having checkstylemeta-.* file name in the sevntu repo(PR: sevntu-checkstyle/sevntu.checkstyle#821). Hence proving third party module integration

Custom config having only Empty Public Ctor in Class Check

[romani]

@gaurabdg , same as in sonar plugin, please provide prove (screenshots) that new file is taken in priority over existed config.
and that Check is actually can be saved in UI and working :).
Please confirm that SEVNTU extension project is working also as before - no breaking changes.

[romani]

@Calixte or @lkoe , please review code update for POC of new metadata files and their support in plugin.
reminder: such files will be located in checkstyle.jar.

[romani]

@gaurabdg , please add one more metafile with Tokens, we need few very different and representative files in this PR.

[gaurabdg]

@gaurabdg , please add one more metafile with Tokens, we need few very different and representative files in this PR.

@romani Please check description, I have provided all proofs and verification screenshots, please let me know if something else is needed.

[romani]

@gaurabdg , make it regular PR.
Let's prepare for merge.

Please confirm that SEVNTU extension

I do not see screenshots for this.

Please also show that configured Checks are running fine.

[Calixte]

What is this change for?

[gaurabdg]

My IDE build failed for these cases, thats why I had to add them

[romani]

test of sevntu is must do.
we have to make sure that we are backward compatible.

[gaurabdg]

test of sevntu is must do.
we have to make sure that we are backward compatible.

Please check description, I have provided screenshots.
Also I have provided screenshots for createMeta functionality

[romani]

@gaurabdg , please move all updates for version bump to separate commit (first commit)
Ones #245 is merged it will not be required.

@Calixte , please provide review.

[romani]

https://user-images.githubusercontent.com/23253816/89645628-ce5d2300-d8d7-11ea-9bc0-1ba6b9e3913e.png - does not prove that sentu works, please share that metadata is loaded for any Check and and you can configure it in UI and it executes.

items:

[gaurabdg]

https://user-images.githubusercontent.com/23253816/89645628-ce5d2300-d8d7-11ea-9bc0-1ba6b9e3913e.png - does not prove that sentu works, please share that metadata is loaded for any Check and and you can configure it in UI and it executes.

Done

[romani]

items:

[romani]

Please remove from commit net.sf.eclipsecs.core/lib/metadata-gen-1.0-SNAPSHOT.jar please make sure you never have it.

Item:

[romani]

items:

[romani]

one item in not resolved from top.

few more minors:

[romani]

Items'

[romani]

@Calixte , please finalize review.

[Calixte]

The plugin is broken since this PR. Adding checks through the UI doesn't work anymore.

[Calixte]

moduleDetails.getParent() will return the full qualified name of the parent, while RuleMetadata expects the simple name of the parent. This breaks the plugin.