Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit webhook request body size #15

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Limit webhook request body size #15

merged 1 commit into from
Jul 24, 2024

Conversation

julik
Copy link
Contributor

@julik julik commented Jul 24, 2024

We are effectively saving arbitrary data into the DB. This can be a large attack vector where random senders can spam the database with data and cause a denial of service. With background validation, this is one of the few cases where we want to reject the payload without persisting it.

@julik julik requested a review from skatkov July 24, 2024 12:50
@julik julik changed the title Verify request body size Limit webhook request body size Jul 24, 2024
Copy link
Contributor

@skatkov skatkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julik julik merged commit 1754112 into main Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants