Cookstyle Bot Auto Corrections with Cookstyle 7.31.1 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cookstyle[bot]](https://avatars.githubusercontent.com/in/78849?s=60&v=4){kind=small}
This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.31.1). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client. ### Style/StringLiterals - **/Berksfile:1**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/Rakefile:24**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:9**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:10**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:11**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:12**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:39**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:40**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:41**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:42**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:43**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:44**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:45**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:80**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:98**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:112**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:112**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:112**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:114**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:128**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:129**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:130**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:131**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:132**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:133**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:134**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:136**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:138**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:139**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:141**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:152**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:170**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:195**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/libraries/default.rb:200**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/recipes/default.rb:25**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/fixtures/ark_spec/recipes/install_windows.rb:6**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/fixtures/ark_spec/recipes/install_windows.rb:7**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:20**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:21**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:24**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:25**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:28**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:30**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:33**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:35**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:38**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:40**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:43**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:45**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:48**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:50**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:110**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:131**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:173**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) - **/spec/recipes/default_spec.rb:199**: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals) ### Style/HashSyntax - **/Rakefile:14**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/Rakefile:15**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/Rakefile:21**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/Rakefile:46**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/Rakefile:47**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/Rakefile:56**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/Rakefile:59**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/providers/default.rb:92**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:27**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:27**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:28**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:28**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:29**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:29**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:30**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:30**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:31**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:31**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:32**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:32**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:33**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:33**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:34**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:34**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:35**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:35**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:36**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:36**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:37**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:38**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:38**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:39**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:39**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:40**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:40**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:41**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:41**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:42**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:42**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:43**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:43**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:44**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:44**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:45**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:45**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:46**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:46**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:47**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:47**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:48**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:48**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:49**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:49**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:50**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:50**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) - **/resources/default.rb:51**: Use the new Ruby 1.9 hash syntax. (https://rubystyle.guide#hash-literals) ### Style/TrailingCommaInHashLiteral - **/Rakefile:15**: Put a comma after the last item of a multiline hash. ### Layout/EmptyLines - **/attributes/default.rb:19**: Extra blank line detected. (https://rubystyle.guide#two-or-more-empty-lines) ### Chef/RedundantCode/MultiplePlatformChecks - **/attributes/default.rb:24**: You can pass multiple values to the platform? and platform_family? helpers instead of calling the helpers multiple times. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_multipleplatformchecks) ### Layout/EmptyLinesAroundModuleBody - **/libraries/default.rb:6**: Extra empty line detected at module body beginning. (https://rubystyle.guide#empty-lines-around-bodies) ### Style/SignalException - **/libraries/default.rb:13**: Always use `raise` to signal exceptions. (https://rubystyle.guide#prefer-raise-over-fail) ### Chef/Style/UsePlatformHelpers - **/libraries/default.rb:35**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) - **/libraries/default.rb:108**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) - **/libraries/default.rb:123**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) - **/libraries/default.rb:172**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) - **/libraries/default.rb:204**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) - **/providers/default.rb:71**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) - **/recipes/default.rb:25**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) ### Style/ConditionalAssignment - **/libraries/default.rb:163**: Use the return of the conditional for variable assignment and comparison. - **/libraries/default.rb:172**: Use the return of the conditional for variable assignment and comparison. - **/libraries/default.rb:204**: Use the return of the conditional for variable assignment and comparison. ### Layout/IndentationWidth - **/libraries/default.rb:163**: Use 2 (not -17) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/default.rb:165**: Use 2 (not -17) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/default.rb:172**: Use 2 (not -18) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/default.rb:174**: Use 2 (not -18) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/default.rb:204**: Use 2 (not 8) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/default.rb:204**: Use 2 (not -4) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/default.rb:206**: Use 2 (not 8) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/libraries/default.rb:206**: Use 2 (not -4) spaces for indentation. (https://rubystyle.guide#spaces-indentation) ### Layout/ElseAlignment - **/libraries/default.rb:164**: Align `else` with `if`. - **/libraries/default.rb:173**: Align `else` with `if`. - **/libraries/default.rb:205**: Align `else` with `if`. - **/libraries/default.rb:205**: Align `else` with `if`. ### Layout/ExtraSpacing - **/libraries/default.rb:178**: Unnecessary spacing detected. - **/libraries/default.rb:178**: Unnecessary spacing detected. - **/libraries/default.rb:184**: Unnecessary spacing detected. - **/libraries/default.rb:186**: Unnecessary spacing detected. - **/libraries/default.rb:186**: Unnecessary spacing detected. - **/libraries/default.rb:191**: Unnecessary spacing detected. - **/libraries/default.rb:191**: Unnecessary spacing detected. ### Layout/SpaceAroundOperators - **/libraries/default.rb:178**: Operator `=` should be surrounded by a single space. (https://rubystyle.guide#spaces-operators) - **/libraries/default.rb:184**: Operator `=` should be surrounded by a single space. (https://rubystyle.guide#spaces-operators) - **/libraries/default.rb:186**: Operator `=` should be surrounded by a single space. (https://rubystyle.guide#spaces-operators) - **/libraries/default.rb:191**: Operator `=` should be surrounded by a single space. (https://rubystyle.guide#spaces-operators) ### Style/RedundantAssignment - **/libraries/default.rb:203**: Redundant assignment before returning detected. ### Layout/EndAlignment - **/libraries/default.rb:207**: `end` at 207, 14 is not aligned with `if` at 203, 8. ### Layout/EmptyLinesAroundMethodBody - **/libraries/default.rb:208**: Extra empty line detected at method body end. (https://rubystyle.guide#empty-lines-around-bodies) ### Layout/TrailingWhitespace - **/libraries/default.rb:208**: Trailing whitespace detected. (https://rubystyle.guide#no-trailing-whitespace) ### Chef/Modernize/DefinesChefSpecMatchers - **/libraries/matchers.rb:1**: ChefSpec matchers are now auto generated by ChefSpec 7.1+ and do not need to be defined in a cookbook (https://docs.chef.io/workstation/cookstyle/chef_modernize_defineschefspecmatchers) ### Chef/Sharing/InvalidLicenseString - **/metadata.rb:4**: Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved". See https://spdx.org/licenses/ for a complete list of license identifiers. (https://docs.chef.io/workstation/cookstyle/chef_sharing_invalidlicensestring) - **/spec/fixtures/ark_spec/metadata.rb:4**: Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved". See https://spdx.org/licenses/ for a complete list of license identifiers. (https://docs.chef.io/workstation/cookstyle/chef_sharing_invalidlicensestring) ### Chef/RedundantCode/LongDescriptionMetadata - **/metadata.rb:6**: The long_description metadata.rb method is not used and is unnecessary in cookbooks. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_longdescriptionmetadata) - **/spec/fixtures/ark_spec/metadata.rb:6**: The long_description metadata.rb method is not used and is unnecessary in cookbooks. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_longdescriptionmetadata) ### Chef/RedundantCode/RecipeMetadata - **/metadata.rb:9**: The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the cookbook's README.md file instead. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_recipemetadata) ### Chef/Modernize/UnnecessaryDependsChef14 - **/metadata.rb:15**: Don't depend on cookbooks made obsolete by Chef Infra Client 14.0+. These community cookbooks contain resources that are now included in Chef Infra Client itself. (https://docs.chef.io/workstation/cookstyle/chef_modernize_unnecessarydependschef14) ### Chef/Style/CommentFormat - **/providers/default.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/providers/default.rb:7**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/providers/default.rb:8**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/default.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/default.rb:6**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/resources/default.rb:2**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/resources/default.rb:6**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) ### Chef/Deprecations/UseInlineResourcesDefined - **/providers/default.rb:23**: use_inline_resources is now the default for resources in Chef Infra Client 13+ and does not need to be specified. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_useinlineresourcesdefined) ### Lint/UnifiedInteger - **/resources/default.rb:28**: Use `Integer` instead of `Fixnum`. - **/resources/default.rb:39**: Use `Integer` instead of `Fixnum`. ### Chef/Deprecations/DeprecatedChefSpecPlatform - **/spec/recipes/default_spec.rb:56**: Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/main/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3 (https://docs.chef.io/workstation/cookstyle/chef_deprecations_deprecatedchefspecplatform) - **/spec/recipes/default_spec.rb:118**: Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/main/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3 (https://docs.chef.io/workstation/cookstyle/chef_deprecations_deprecatedchefspecplatform) - **/spec/recipes/default_spec.rb:139**: Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/main/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3 (https://docs.chef.io/workstation/cookstyle/chef_deprecations_deprecatedchefspecplatform) ### Layout/EmptyLinesAroundBlockBody - **/spec/recipes/default_spec.rb:90**: Extra empty line detected at block body end. (https://rubystyle.guide#empty-lines-around-bodies) - **/spec/resources/default_spec.rb:145**: Extra empty line detected at block body end. (https://rubystyle.guide#empty-lines-around-bodies) ### Layout/TrailingEmptyLines - **/spec/spec_helper.rb:3**: 2 trailing blank lines detected. (https://rubystyle.guide#newline-eof) ### Chef/Deprecations/ChefSpecCoverageReport - **/spec/spec_helper.rb:4**: Don't use the deprecated ChefSpec coverage report functionality in your specs. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_chefspeccoveragereport) Signed-off-by: Cookstyle <cookbooks@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.31.1). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client.
Style/StringLiterals
Style/HashSyntax
Style/TrailingCommaInHashLiteral
Layout/EmptyLines
Chef/RedundantCode/MultiplePlatformChecks
Layout/EmptyLinesAroundModuleBody
Style/SignalException
raiseto signal exceptions. (https://rubystyle.guide#prefer-raise-over-fail)Chef/Style/UsePlatformHelpers
Style/ConditionalAssignment
Layout/IndentationWidth
Layout/ElseAlignment
elsewithif.elsewithif.elsewithif.elsewithif.Layout/ExtraSpacing
Layout/SpaceAroundOperators
=should be surrounded by a single space. (https://rubystyle.guide#spaces-operators)=should be surrounded by a single space. (https://rubystyle.guide#spaces-operators)=should be surrounded by a single space. (https://rubystyle.guide#spaces-operators)=should be surrounded by a single space. (https://rubystyle.guide#spaces-operators)Style/RedundantAssignment
Layout/EndAlignment
endat 207, 14 is not aligned withifat 203, 8.Layout/EmptyLinesAroundMethodBody
Layout/TrailingWhitespace
Chef/Modernize/DefinesChefSpecMatchers
Chef/Sharing/InvalidLicenseString
Chef/RedundantCode/LongDescriptionMetadata
Chef/RedundantCode/RecipeMetadata
Chef/Modernize/UnnecessaryDependsChef14
Chef/Style/CommentFormat
Chef/Deprecations/UseInlineResourcesDefined
Lint/UnifiedInteger
Integerinstead ofFixnum.Integerinstead ofFixnum.Chef/Deprecations/DeprecatedChefSpecPlatform
Layout/EmptyLinesAroundBlockBody
Layout/TrailingEmptyLines
Chef/Deprecations/ChefSpecCoverageReport
Signed-off-by: Cookstyle cookbooks@chef.io