Refactor deploy #326
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,167 @@ | ||
| name: Continuous deployment | ||
|
|
||
| on: | ||
| push: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| lint-python: | ||
| name: Lint Python code | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - id: checkout | ||
| name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - id: setup-python | ||
| name: Setup Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.9' | ||
| cache: 'pipenv' | ||
|
|
||
| - id: install-pipenv | ||
| name: Install pipenv | ||
| run: curl https://raw.githubusercontent.com/pypa/pipenv/master/get-pipenv.py | python | ||
| shell: bash | ||
|
|
||
| - id: install-python-dependencies | ||
| name: Install Python dependencies | ||
| run: pipenv sync --dev | ||
| shell: bash | ||
|
|
||
| - id: lint | ||
| name: Lint Python code | ||
| run: pipenv run flake8 ./datawrapper --verbose | ||
| shell: bash | ||
|
|
||
| mypy-python: | ||
| name: Static-types check | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - id: setup-python | ||
| name: Setup Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.9' | ||
| cache: 'pipenv' | ||
|
|
||
| - id: install-pipenv | ||
| name: Install pipenv | ||
| run: curl https://raw.githubusercontent.com/pypa/pipenv/master/get-pipenv.py | python | ||
| shell: bash | ||
|
|
||
| - id: install-python-dependencies | ||
| name: Install Python dependencies | ||
| run: pipenv sync --dev | ||
| shell: bash | ||
|
|
||
| - id: mypy | ||
| name: Run mypy | ||
| run: pipenv run mypy ./datawrapper --ignore-missing-imports --verbose | ||
| shell: bash | ||
|
Comment on lines
+38
to
+65
There was a problem hiding this comment.
I'm not sure that it's needed. Any opinions? Happy to leave this in for now and take this up in a different conversation. There was a problem hiding this comment. I'm a fan of keeping it. We can beef up its implementation further on down the road. I use it for all my stuff at this point in a scheme similar to the one proposed here. Holds up great. |
||
|
|
||
| test-python: | ||
| name: Test Python code | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python: ['3.8', '3.9', '3.10', '3.11'] | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - id: setup-python | ||
| name: Setup Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '${{ matrix.python }}' | ||
| cache: 'pipenv' | ||
|
|
||
| - id: install-pipenv | ||
| name: Install pipenv | ||
| run: curl https://raw.githubusercontent.com/pypa/pipenv/master/get-pipenv.py | python | ||
| shell: bash | ||
|
|
||
| - id: install-python-dependencies | ||
| name: Install Python dependencies | ||
| run: pipenv install --dev --python=${{ matrix.python }} --skip-lock | ||
| shell: bash | ||
|
|
||
| - id: tests | ||
| name: Run tests | ||
| run: pipenv run python -m pytest --cov -sv | ||
| shell: bash | ||
|
|
||
| build: | ||
| name: Build release candidate | ||
| runs-on: ubuntu-latest | ||
| needs: [test-python] | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - id: setup-python | ||
| name: Setup Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.9' | ||
| cache: 'pipenv' | ||
|
|
||
| - id: install-pipenv | ||
| name: Install pipenv | ||
| run: curl https://raw.githubusercontent.com/pypa/pipenv/master/get-pipenv.py | python | ||
| shell: bash | ||
|
|
||
| - id: install-python-dependencies | ||
| name: Install Python dependencies | ||
| run: pipenv install --dev --deploy | ||
| shell: bash | ||
|
|
||
| - id: build-source | ||
| name: Build source release | ||
| run: pipenv run python setup.py sdist | ||
| shell: bash | ||
|
|
||
| - id: build-binary | ||
| name: Build binary release | ||
| run: pipenv run python setup.py bdist_wheel | ||
| shell: bash | ||
|
|
||
| - id: check | ||
| name: Check release | ||
| run: pipenv run twine check dist/* | ||
| shell: bash | ||
|
|
||
| - id: save | ||
| name: Save artifact | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: release-candidate | ||
| path: ./dist | ||
| if-no-files-found: error | ||
|
|
||
| release: | ||
| name: PyPI release | ||
| runs-on: ubuntu-latest | ||
| needs: [build] | ||
| if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags') | ||
| steps: | ||
| - id: fetch | ||
| name: Fetch artifact | ||
| uses: actions/download-artifact@v3 | ||
| with: | ||
| name: release-candidate | ||
| path: ./dist | ||
|
|
||
| - id: publish | ||
| name: Publish release | ||
| uses: pypa/gh-action-pypi-publish@release/v1 | ||
| with: | ||
| user: __token__ | ||
| password: ${{ secrets.PYPI_API_TOKEN }} | ||
| verbose: true | ||
| verify_metadata: false | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much! I've been meaning to simplify this process since the beginning 😅