Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pr): add template for PR #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

juandahl
Copy link

@juandahl juandahl commented Aug 14, 2024

Description

Add template for PR.

Type of Change

  • bugfix
  • feature
  • enhancement
  • refactor
  • style
  • docs
  • chore

Scope

  • frontend
  • backend
  • fullstack
  • infra
  • tests
  • UI/UX

Priority

  • high-priority
  • medium-priority
  • low-priority

Specific Changes

  • variable-rename
  • linter-fix
  • prettier-fix

Dependencies

  • blocked
  • blocking

Mandatory Reviewers

@chescalante

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

Add any other context or screenshots about the pull request here.

Copy link

@njaume njaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICEE

@chescalante
Copy link
Owner

LG, could you add two extra sections?

  1. To put video/images
  2. To put link to the jira issue?

@juandahl

Comment on lines +7 to +30
### Type of Change

- [ ] bugfix
- [ ] feature
- [ ] enhancement
- [ ] refactor
- [ ] style
- [ ] docs
- [ ] chore

### Scope

- [ ] frontend
- [ ] backend
- [ ] fullstack
- [ ] infra
- [ ] tests
- [ ] UI/UX

### Priority

- [ ] high-priority
- [ ] medium-priority
- [ ] low-priority

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for these we may be better off using labels to get more visibility in the pr listing like this

image

Comment on lines +45 to +50
@Code-Quality-UI-Specialist
@Architecture-Design-Reviewer
@Cloud-Infrastructure-Reviewer
@Testing-Specialist
@UI-UX-Reviewer
@Tech-Leader

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well maybe better use GitHub to request
image

Copy link

@matzapata matzapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Really useful!! Added some small comments as improvement ideas. Also maybe reduce checklist where needed so we don't get a feel from unfinished in the pr listing

image

But details, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants