Revive PR#1067 #1139
Merged
Revive PR#1067 #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In reality, a hold can only be have one scheduled appointment at a time. Also makes sure that when a hold is destroyed, its associated appointment hold join record is destroyed.
If a hold is canceled by a member, it is removed from any associated appointments. If it was the only item in the appointment, the appointment is also canceled.
jim
force-pushed
the
sm-remove-hold-from-appointment
branch
from
7163b0b to
58f41fc
Compare
phinze
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will merge in the work done by @stephanieminn in #1067:
What it does
Why it is important
Resolves #802 and #666!
UI Change Screenshot
Alert when a user tries to remove a hold associated with an appointment:
Implementation notes
I noticed that
Holdwas defined to have ahas_manyrelationship with appointments, but experimenting with the app led me to believe that it shouldn't be possible for a hold to be added to any other appointment. As a result, I did a lil refactor to enforce that a holdhas_oneappointment relationship to make the subsequent work easier.I also added a
dependent: :destroystrategy for appointment holds to avoid orphaned records when a hold is destroyed. If these were the wrong assumptions, please let me know!