Fix appointment merging bug #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a member schedules a new appointment with the same time as an existing one, we merge the appointments together. However, we were still sending an email with an appointment argument that was the appointment that no longer existed after the merge. This led to deserialization errors when the mail job was later processed.
…email and gracefully handle cases where the current appointment is merged into a preexisting one.
phinze
approved these changes
Oct 13, 2023
README.md
Outdated
| - [Buildpacks](#buildpacks) | ||
| - [Release Command](#release-command) | ||
| - [Daily Summary Emails](#daily-summary-emails) | ||
| - [Alternatives](#alternatives) |
There was a problem hiding this comment.
This looks like it might be diff noise from separate README sprucing?
There was a problem hiding this comment.
Yeah, this is unintentional. I'll remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR fixes an issue that we've seen in production where an ActiveJob instance fails to deserialize due to an Appointment not being found with a certain ID. I looked through the code, and I think the likely cause of the issue is that in some cases we merge multiple appointments that have been scheduled for the same time slot together, but we were still enqueuing a confirmation email for an Appointment that didn't exist after this merge was performed.
The errors we're seeing in production look like this:
Why it is important
Some members weren't getting confirmation emails, and it's nice to not have recurring errors due to bugs.
Implementation notes
Your bandwidth for additional changes to this PR
Please choose one of the following to help the project maintainers provide the appropriate level of support: