Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show references to payments when allow_payments is false #1158

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

charlorr
Copy link
Contributor

What it does

This PR removes the reference to making payments on the renewals home page when payments are disabled by the library.

Why it is important

Disable online payments using Library setting#1146

UI Change Screenshot

Before (with payments disabled by the library):
image

After (with payments disabled):
image

After (with payments enabled):
image

Your bandwidth for additional changes to this PR

Please choose one of the following to help the project maintainers provide the appropriate level of support:

  • I have the time and interest to make additional changes to this PR based on feedback.
  • I am interested in feedback but don't need to make the changes myself.
  • I don't have time or interest in making additional changes to this work.
  • Other or not sure (please describe):

Copy link
Member

@jim jim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the attention to detail here, and that you took the time to fully understand what the code was actually doing 😄

@jim jim merged commit 75115ae into main Oct 16, 2023
@jim jim deleted the renewal-allow_payments-conditional branch October 16, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants