Remove special chars from JSON message to make widget more robust

[xpix]

No description provided.

[chilipeppr]

Hi Frank,

I'm not comfortable putting that change in there. I think this is the kind
of code that creates issues in the future when somebody is actually trying
to send these characters and nobody can figure out why they aren't getting
through. The only thing I would feel comfortable with is looking for
something that would only detect from TinyG and only fix TinyG, but nothing
broader.

The other problem here fundamentally is TinyG shouldn't be sending a bad
character, so I'd much rather solve this by getting Alden to update the
firmware so no weird characters are being sent.

-John

On Thu, Nov 17, 2016 at 6:30 AM, Frank Herrmann [email protected]
wrote:

---

You can view, comment on, or merge this pull request online at:

#3
Commit Summary

• remove special characters from JSON text
• Made some changes to ChiliPeppr widget using Cloud9
• remove all special ASCII Chars
• Made some changes to ChiliPeppr widget using Cloud9

File Changes

• M README.md
  https://github.com/chilipeppr/widget-spjs/pull/3/files#diff-0 (12)
• M auto-generated-widget.html
  https://github.com/chilipeppr/widget-spjs/pull/3/files#diff-1 (13)
• M widget.js
  https://github.com/chilipeppr/widget-spjs/pull/3/files#diff-2 (5)

Patch Links:

• https://github.com/chilipeppr/widget-spjs/pull/3.patch
• https://github.com/chilipeppr/widget-spjs/pull/3.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#3, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHidbc2C7w5V-Aq2WInd4uq0zL0qx5dDks5q_GTygaJpZM4K1Xxx
.

[xpix]

Ok, no problem. I can also add a console message if found we not allowed characters in JSON.

But yes, we should inform alden.

Am 17.11.2016 um 17:19 schrieb John Lauer [email protected]:

Hi Frank,

I'm not comfortable putting that change in there. I think this is the kind
of code that creates issues in the future when somebody is actually trying
to send these characters and nobody can figure out why they aren't getting
through. The only thing I would feel comfortable with is looking for
something that would only detect from TinyG and only fix TinyG, but nothing
broader.

The other problem here fundamentally is TinyG shouldn't be sending a bad
character, so I'd much rather solve this by getting Alden to update the
firmware so no weird characters are being sent.

-John

On Thu, Nov 17, 2016 at 6:30 AM, Frank Herrmann [email protected]
wrote:

---

You can view, comment on, or merge this pull request online at:

#3
Commit Summary

• remove special characters from JSON text
• Made some changes to ChiliPeppr widget using Cloud9
• remove all special ASCII Chars
• Made some changes to ChiliPeppr widget using Cloud9

File Changes

• M README.md
  https://github.com/chilipeppr/widget-spjs/pull/3/files#diff-0 (12)
• M auto-generated-widget.html
  https://github.com/chilipeppr/widget-spjs/pull/3/files#diff-1 (13)
• M widget.js
  https://github.com/chilipeppr/widget-spjs/pull/3/files#diff-2 (5)

Patch Links:

• https://github.com/chilipeppr/widget-spjs/pull/3.patch
• https://github.com/chilipeppr/widget-spjs/pull/3.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#3, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHidbc2C7w5V-Aq2WInd4uq0zL0qx5dDks5q_GTygaJpZM4K1Xxx
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.