Fixed problem with env in settings.py and updated README about ALLOWED_HOSTS #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of improvements from user feedback on discord.
Apparently, environment variables coming from
env
are string by default and not automatically cast to higher-level types such as lists. To ensure correct behavior, I rewrote theenv
lines insettings.py
to only depend on strings.I also added a small note on
DJANGO_ALLOWED_HOSTS
to the README as it caused some trouble in a setup.