-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix POST voyages/teams/{teamId}/techs bug #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that techs.e2e-spec test should also be updated with a test case for this scenario
@JoshuaHinman could you please resolve merge conflicts when you have a chance? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the changes in Swagger, the issue has been resolved, and all tests have successfully passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix the changelog when I merge my latest PR, too many different changelog versions now 😂
Description
This PR fixes a bug in which a user can create a new tech for a category that doesn't belong to their team.
Issue link
Fixes # 86b2n3gbr
Type of change
How Has This Been Tested?
yarn test
In swagger, verified that creating a tech within another team's category throws an error:
Checklist: