Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: setup release please #235

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Chore: setup release please #235

merged 3 commits into from
Jan 30, 2025

Conversation

cherylli
Copy link
Contributor

@cherylli cherylli commented Dec 29, 2024

Description

Create Release please yml file. The changes probably won't take effect till after next time we merge into main. It has been tested on my fork repo. We will need to make sure we start using squashed, conventional commits.

Fork: https://github.com/cherylli/chingu-dashboard-be/pulls
Release please: https://github.com/googleapis/release-please
Conventional commits: https://www.conventionalcommits.org/en/v1.0.0/
Squashing commits:
https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together
https://github.com/chingu-x/chingu-dashboard-be/wiki/Getting-Started

We will still maintain the changelog in the period of transition, till we completely follow conventional commits

Updated Wiki: https://github.com/chingu-x/chingu-dashboard-be/wiki/Getting-Started

Issue link

BE-25-013

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@cherylli cherylli self-assigned this Dec 29, 2024
@cherylli cherylli marked this pull request as draft December 29, 2024 14:26
@cherylli cherylli marked this pull request as ready for review December 30, 2024 06:30
@cherylli cherylli requested review from timDeHof and curtwl January 16, 2025 02:23
Copy link

@timDeHof, @curtwl
One business day has passed since the review started. Give priority to reviews as much as possible.

Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git action for my fork worked but created a new branch with the new changelog.md in it.

@cherylli
Copy link
Contributor Author

The git action for my fork worked but created a new branch with the new changelog.md in it.

did you have a changelog.md in your fork? Mine just appended to the existing one.

@timDeHof
Copy link
Contributor

The git action for my fork worked but created a new branch with the new changelog.md in it.

did you have a changelog.md in your fork? Mine just appended to the existing one.

no, I didn't have one. I created a working branch of the main branch of my fork.

@cherylli cherylli merged commit 9e2d3ca into dev Jan 30, 2025
1 check passed
@cherylli cherylli deleted the chore/setup-release-please branch January 30, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants