-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix declaration order #265
Fix declaration order #265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
verible-verilog-lint
design/dec/el2_dec_tlu_ctl.sv|792 col 15| Explicitly define a storage type for every parameter and localparam, (MEICURPL). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|798 col 15| Explicitly define a storage type for every parameter and localparam, (MEICIDPL). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|804 col 15| Explicitly define a storage type for every parameter and localparam, (MEICPCT). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|810 col 15| Explicitly define a storage type for every parameter and localparam, (MEIPT). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|829 col 15| Explicitly define a storage type for every parameter and localparam, (DCSR). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|834 col 15| Explicitly define a storage type for every parameter and localparam, (DPC). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|845 col 15| Explicitly define a storage type for every parameter and localparam, (DICAWICS). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|859 col 15| Explicitly define a storage type for every parameter and localparam, (DICAD0). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|867 col 15| Explicitly define a storage type for every parameter and localparam, (DICAD0H). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|872 col 15| Explicitly define a storage type for every parameter and localparam, (DICAGO). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|877 col 15| Explicitly define a storage type for every parameter and localparam, (MHPMC3). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|878 col 15| Explicitly define a storage type for every parameter and localparam, (MHPMC3H). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|887 col 15| Explicitly define a storage type for every parameter and localparam, (MHPMC4). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|888 col 15| Explicitly define a storage type for every parameter and localparam, (MHPMC4H). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|897 col 15| Explicitly define a storage type for every parameter and localparam, (MHPMC5). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|898 col 15| Explicitly define a storage type for every parameter and localparam, (MHPMC5H). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|907 col 15| Explicitly define a storage type for every parameter and localparam, (MHPMC6). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|908 col 15| Explicitly define a storage type for every parameter and localparam, (MHPMC6H). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|917 col 15| Explicitly define a storage type for every parameter and localparam, (MHPME3). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|922 col 15| Explicitly define a storage type for every parameter and localparam, (MHPME4). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|927 col 15| Explicitly define a storage type for every parameter and localparam, (MHPME5). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|932 col 15| Explicitly define a storage type for every parameter and localparam, (MHPME6). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|944 col 15| Explicitly define a storage type for every parameter and localparam, (MCOUNTINHIBIT). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|949 col 15| Explicitly define a storage type for every parameter and localparam, (MTSEL). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|954 col 15| Explicitly define a storage type for every parameter and localparam, (MTDATA1). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|959 col 15| Explicitly define a storage type for every parameter and localparam, (MTDATA2). [Style: constants] [explicit-parameter-storage-type]
design/dec/el2_dec_tlu_ctl.sv|3163 col 27| File must end with a newline. [Style: posix-file-endings] [posix-eof]
// [12] M - integer mul/div | ||
// [8] I - RV32I | ||
// [2] C - Compressed extension | ||
localparam MISA = 12'h301; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MISA). [Style: constants] [explicit-parameter-storage-type]
localparam MISA = 12'h301; | ||
|
||
// MVENDORID, MARCHID, MIMPID, MHARTID | ||
localparam MVENDORID = 12'hf11; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MVENDORID). [Style: constants] [explicit-parameter-storage-type]
|
||
// MVENDORID, MARCHID, MIMPID, MHARTID | ||
localparam MVENDORID = 12'hf11; | ||
localparam MARCHID = 12'hf12; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MARCHID). [Style: constants] [explicit-parameter-storage-type]
// MVENDORID, MARCHID, MIMPID, MHARTID | ||
localparam MVENDORID = 12'hf11; | ||
localparam MARCHID = 12'hf12; | ||
localparam MIMPID = 12'hf13; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MIMPID). [Style: constants] [explicit-parameter-storage-type]
localparam MVENDORID = 12'hf11; | ||
localparam MARCHID = 12'hf12; | ||
localparam MIMPID = 12'hf13; | ||
localparam MHARTID = 12'hf14; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MHARTID). [Style: constants] [explicit-parameter-storage-type]
// MICCMECT (ICCM error counter/threshold) | ||
// [31:27] : ICCM parity error threshold | ||
// [26:0] : ICCM parity error count | ||
localparam MICCMECT = 12'h7f1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MICCMECT). [Style: constants] [explicit-parameter-storage-type]
// MDCCMECT (DCCM error counter/threshold) | ||
// [31:27] : DCCM parity error threshold | ||
// [26:0] : DCCM parity error count | ||
localparam MDCCMECT = 12'h7f2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MDCCMECT). [Style: constants] [explicit-parameter-storage-type]
// MFDHT (Force Debug Halt Threshold) | ||
// [5:1] : Halt timeout threshold (power of 2) | ||
// [0] : Halt timeout enabled | ||
localparam MFDHT = 12'h7ce; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MFDHT). [Style: constants] [explicit-parameter-storage-type]
// MFDHS(RW) | ||
// [1] : LSU operation pending when debug halt threshold reached | ||
// [0] : IFU operation pending when debug halt threshold reached | ||
localparam MFDHS = 12'h7cf; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MFDHS). [Style: constants] [explicit-parameter-storage-type]
// MEIVT (External Interrupt Vector Table (R/W)) | ||
// [31:10]: Base address (R/W) | ||
// [9:0] : Reserved, reads 0x0 | ||
localparam MEIVT = 12'hbc8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MEIVT). [Style: constants] [explicit-parameter-storage-type]
// MEICURPL (R/W) | ||
// [31:4] : Reserved (read 0x0) | ||
// [3:0] : CURRPRI - Priority level of current interrupt service routine (R/W) | ||
localparam MEICURPL = 12'hbcc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MEICURPL). [Style: constants] [explicit-parameter-storage-type]
// MEICIDPL (R/W) | ||
// [31:4] : Reserved (read 0x0) | ||
// [3:0] : External Interrupt Claim ID's Priority Level Register | ||
localparam MEICIDPL = 12'hbcb; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MEICIDPL). [Style: constants] [explicit-parameter-storage-type]
// MEICPCT (Capture CLAIMID in MEIHAP and PL in MEICIDPL | ||
// [31:1] : Reserved (read 0x0) | ||
// [0] : Capture (W1, Read 0) | ||
localparam MEICPCT = 12'hbca; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MEICPCT). [Style: constants] [explicit-parameter-storage-type]
// MEIPT (External Interrupt Priority Threshold) | ||
// [31:4] : Reserved (read 0x0) | ||
// [3:0] : PRITHRESH | ||
localparam MEIPT = 12'hbc9; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MEIPT). [Style: constants] [explicit-parameter-storage-type]
// [2] : step | ||
// [1:0] : prv (0x3 for this core) | ||
// | ||
localparam DCSR = 12'h7b0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (DCSR). [Style: constants] [explicit-parameter-storage-type]
// [1] : reserved, read 0x0 | ||
// [0] : MCYCLE disable | ||
|
||
localparam MCOUNTINHIBIT = 12'h320; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MCOUNTINHIBIT). [Style: constants] [explicit-parameter-storage-type]
// ---------------------------------------------------------------------- | ||
// MTSEL (R/W) | ||
// [1:0] : Trigger select : 00, 01, 10 are data/address triggers. 11 is inst count | ||
localparam MTSEL = 12'h7a0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MTSEL). [Style: constants] [explicit-parameter-storage-type]
// ---------------------------------------------------------------------- | ||
// MTDATA1 (R/W) | ||
// [31:0] : Trigger Data 1 | ||
localparam MTDATA1 = 12'h7a1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MTDATA1). [Style: constants] [explicit-parameter-storage-type]
// ---------------------------------------------------------------------- | ||
// MTDATA2 (R/W) | ||
// [31:0] : Trigger Data 2 | ||
localparam MTDATA2 = 12'h7a2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly define a storage type for every parameter and localparam, (MTDATA2). [Style: constants] [explicit-parameter-storage-type]
@@ -2879,4 +3160,4 @@ import el2_pkg::*; | |||
); | |||
|
|||
|
|||
endmodule // dec_timer_ctl | |||
endmodule // dec_timer_ctl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File must end with a newline. [Style: posix-file-endings] [posix-eof]
reviewdog suggestion error
GitHub comment range and suggestion line range must be same. L3163-L3163 v.s. L3163-L31641e12d4f
to
5516b4f
Compare
5516b4f
to
0e046f1
Compare
Links to coverage and verification reports for this PR (#265) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/ |
1 similar comment
Links to coverage and verification reports for this PR (#265) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/ |
This PR fixes declaration order in el2_dec_tlu_ctl.sv.
Should resolve #261.