misc fpv fixes #88
Merged
misc fpv fixes #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed keccak to always drive ready low if it isn't ready changed keccak pad to start keccak even if receiving a partial in the same clock cycle
…h updated timestamp and hash after successful run
* Fixup UVM assertion reporting for 1.1d compatibility * MICROSOFT AUTOMATED PIPELINE: Stamp 'cwhitehead-msft-uvm-assert-fixups' with updated timestamp and hash after successful run
* converted spec to md format * changed the format * updated images * removed TOC * converted to md file * added Pseudocode * added perf resuls * added single sign perf resuls * updated the tables * updated API * removed docs file * updated area results * updated tables * fixed API and psedocode * signing perf * added a note for freq * updated sub-sections * updated equations * updated more equations * MICROSOFT AUTOMATED PIPELINE: Stamp 'mojtaba-md_spec' with updated timestamp and hash after successful run
…yvault flow is running fixed spurious state valid dv in sha3 block when controller doesn't immediately assert a new run command
…h updated timestamp and hash after successful run
mojtaba-bisheh
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed msg inf so it won't latch new data if msg hold is asserted. Fixes corner case where msg cnt could increment from 0 -> 1 and we'd lose the data if first msg was held.
Changed keccak to always drive ready low if it isn't ready. Hold shouldn't be dependent on valid whenever possible.
Changed keccak pad to start keccak even if receiving a partial in the same clock cycle. FPV found that a partial immediately following the last msg of a block would cause keccak to not start until the following cycle due to precedence in if/else statements.
added assertion for checking if zeroize cleared seed. Used in zeroize during kv check in caliptra.
fixed sha3 state dv assertion. Would spuriously assert dv if controller didn't immediately send a run command after accepting the state output.