hmac384 driver: Reload kv keys for each block #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korran
force-pushed
the
hmac-kv-multiblock-fix
branch
2 times, most recently
from
6114364 to
fac136d
Compare
6 tasks
korran
force-pushed
the
hmac-kv-multiblock-fix
branch
2 times, most recently
from
37dafcd to
f7522eb
Compare
korran
requested review from
mhatrevi,
ajisaxena,
vsonims,
JohnTraverAmd and
rusty1968
as code owners
jhand2
approved these changes
Jun 21, 2024
nquarton
approved these changes
Jun 21, 2024
mhatrevi
approved these changes
Jun 24, 2024
This fixes chipsalliance#1520 / chipsalliance#1550: HMAC operations larger than a single block produce the incorrect results when using data or keys from the keyvault.
jhand2
force-pushed
the
hmac-kv-multiblock-fix
branch
from
f7522eb to
725f51e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[bugfix] hmac384 driver: Reload kv keys for each block.
This fixes #1520 / #1550: HMAC operations larger than asingle block produce the incorrect results when using data or keys from the keyvault.
Additional commits in this PR add driver tests and end-to-end tests that validate this scenario.