Fix a memory leak in the HW model. #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhalvorsen
force-pushed
the
zhalvorsen-memory-leak-in-smoke-test
branch
from
688e573 to
84331a8
Compare
zhalvorsen
requested review from
korran,
fdamato,
jlmahowa-amd,
mhatrevi and
jhand2
as code owners
jhand2
approved these changes
Jul 1, 2024
Previously, the `drop` didn't free anything because the compiler thought it was a zero-sized struct. This tells the compiler how much memory needs to be freed.
jhand2
force-pushed
the
zhalvorsen-memory-leak-in-smoke-test
branch
from
84331a8 to
ecb701b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
dropdidn't free anything because the compiler thought it was a zero-sized struct. This tells the compiler how much memory needs to be freed.